If I use com.intellij.openapi.editor.Document as UserDataHolder do I need to remove my keys from it on project close or will they be garbage collected automatically when Project is closed ?
They will be collected when Document is collected by GC, it has much shorter lifetime than Project.