Hi sorry again me asking for a quick approve - sorry about it and thanks!
You probably noticed that your updates are not approved automatically. It is because your code violates Override-only methods usage for some of APIs, this means those APIs are not meant to be called by your code, only by platform.
And it will continue until you get rid of those, there will be waiting and manual check from our side each time.
I went through every override-only finding and in fact I reduce some in previous releases but wanted to flag that those remaing point to APIs the JetBrains SDK documentation itself instructs plugins to use:
1:
Lsp4jClient constructor — the LSP integration guide (language_server_protocol.md) says:
override the
LspServerDescriptor.createLsp4jClient()function and theLsp4jClientclass according to their documentation.
The override signals back the new instance with return MySubclass(handler), which is what the verifier flags.
There is no public factory that avoids invoking the override-only constructor.
2:
UiDataProvider.Companion.wrapComponent(…) - @ApiStatus.OverrideOnly is annotated on the interface itself, so the marker propagates to every member, including the @JvmStatic companion factory whose KDoc says:
Use for simple cases to provide additional data.
The factory is the documented call-side entry point - there is no alternative API.
3:
AnAction.actionPerformed / ActionGroup.getChildren self-delegation — the AnAction JavaDoc explicitly carves out:
do not call them manually except for delegation.
Our ActionGroup delegates to a child AnAction (the unified provider action) — exactly the carved-out exception.
I’ll be more then happy to migrate any of these the moment a non-override-only API exists.
If JetBrains has guidance on a preferred non-override-only path for any of these (especially Lsp4jClient and UiDataProvider.wrapComponent), I’d really appreciate a pointer — happy to update the plugin immediately.
Thanks — Jonathan
Thank you so much, it will definitely help us fix those false-positives!
Sure, so there is a chance to get this version approved? I want to reply to multiple open issues reported by users…
Again sorry about it…